-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi.
> +US_PATH="/usr/sbin/lisp"
> +KMOD_PATH="/usr/sbin"
> +CONF_PATH="/lib/network/lisp"
> +IF_NAME="eth1"
> +
> +# RLOC used in ip rules for source routing
> +#RLOC="128.107.165.94"
> +RLOC=`/sbin/ifconfig eth1 | sed '/inet\ /!d;s/.*r://g;s/\ .*//g'`
Here I'd suggest something like:
IF_NAME=$(uci -q -P /var/state get network.wan.ifname)
RLOC=$(uci -q -P /vat/state get network.wan.ipaddr)
> +sleep 2
> +insmod ${KMOD_PATH}/lisp_int.ko
> +sleep 3
> +insmod ${KMOD_PATH}/lisp.ko
> +sleep 3
Is there a particular reason for the delays or would loading those
modules at startup be fine?
> +/sbin/udhcpc -i $IF_NAME
Why must DHCP be re-requested here? Is the WAN supposed to be DHCP or
could it be static as well?
> Index: package/lisp/src/timerfd.h
> ===================================================================
You attached the complete sourcecode for the daemon here. That is not
wrong per se, but I wonder what the future plans are. Do you plan to
develop it within OpenWrt or will there be an external repository where
the source can be pulled from?
> +# OpenWrt LISP Package
> +# Vasileios Lakafosis ([email protected])
Maybe state a license here.
The rest looks fine so far.
~ Jow
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk6nILIACgkQdputYINPTPOChwCfTsYYb8MfvKIu3bshPtK6wNna
ziEAoI1bhQxyOOp2cWxNvG9BFNnysFkA
=iDdW
-----END PGP SIGNATURE-----
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
