Hi,
> Support for Belkin F5D8235-4 v1 (RT288x)
> works:
> - switch
> - buttons
> - some leds
>
> does not work:
> - USB (not supported by RT288XX)
> - WLAN
>
> Based on r29397
>
> Signed-off-by: Cezary Jackiewicz <[email protected]>
The patch seems good, except the flash handling part. See my comments below.
<...>
> --- target/linux/ramips/files/arch/mips/ralink/rt288x/devices.c
> +++ target/linux/ramips/files/arch/mips/ralink/rt288x/devices.c
> @@ -56,6 +56,21 @@
> .num_resources = ARRAY_SIZE(rt288x_flash1_resources),
> };
>
> +static struct resource rt288x_flash8_resources[] = {
> + {
> + .flags = IORESOURCE_MEM,
> + .start = KSEG1ADDR(RT2880_FLASH0_BASE),
> + .end = KSEG1ADDR(RT2880_FLASH0_BASE) +
> + RT2880_FLASH8_SIZE - 1,
> + },
> +};
This seems wrong. This defines a memory resource from 0x1fc00000 to 0x20400000.
However that overlaps with the PCI memory space, which starts at 0x20000000 on
the RT2880. I'm wondering how you are able to read the whole flash with this.
Maybe this is the reason why you can't use the USB host controller connected to
the PCI bus.
> +
> +static struct platform_device rt288x_flash8_device = {
> + .name = "physmap-flash",
> + .resource = rt288x_flash8_resources,
> + .num_resources = ARRAY_SIZE(rt288x_flash8_resources),
> +};
> +
> static int rt288x_flash_instance __initdata;
> void __init rt288x_register_flash(unsigned int id,
> struct physmap_flash_data *pdata)
> @@ -73,6 +88,10 @@
> pdev = &rt288x_flash1_device;
> reg = MEMC_REG_FLASH_CFG1;
> break;
> + case 8:
Please don't add an invalid entry here. The 'id' argument of the
'rt288x_register_flash' function means the id of the built-in flash controller,
and the RT2880 has only two of such controllers.
-Gabor
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
