On 26 October 2012 06:13, Catalin Patulea <c...@vv.carleton.ca> wrote:
>
> Signed-off-by: Catalin Patulea <c...@vv.carleton.ca>
> ---
> Unlikely myloader.h, bcm963xx_tag.h was already in the kernel tree, so to move
> it, I didn't want to have the patch remove it and to add it through files - so
> the patch does both. It should be easier to update if bcm963xx_tag.h changes
> upstream.
>
> The patch is in linux/generic because if it were in brcm63xx, then 
> non-brcm63xx
> builds would still emit the warning.
>
> You have to run 'make toolchain/kernel-headers/{clean,install}' after applying
> this so the toolchain refreshes exported headers from the kernel and places
> them somewhere in the include path.
>
> Build tested on malta_be and brcm63xx.

bcm63xx does not build for me with this:

Applying patch platform/405-bcm963xx_real_rootfs_length.patch
patching file arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
Hunk #1 FAILED at 85.
1 out of 1 hunk FAILED -- rejects in file
arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
patching file drivers/mtd/bcm63xxpart.c
Patch platform/405-bcm963xx_real_rootfs_length.patch does not apply
(enforce with -f)
make[3]: *** 
[/home/jonas/openwrt/build_dir/linux-brcm63xx/linux-3.3.8/.quilt_checked]
Error 1
make[3]: Leaving directory `/home/jonas/openwrt/target/linux/brcm63xx'
make[2]: *** [install] Error 2

Also I'm not sure the location is correct - maybe it should rather be
linux/mtd/bcm963xx_tag.h or mtd/bcm963xx_tag.h something like that -
linux/ is just so ... generic.

Also, can you please submit this upstream, too? I think the idea is
good, it's just some details that need to be fixed.

Oh, and don't forget that there is a linux-3.6 also in trunk.


Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to