On 5 November 2012 04:16, Catalin Patulea <c...@vv.carleton.ca> wrote:
> On Thu, Nov 1, 2012 at 8:25 AM, Jonas Gorski
> <jonas.gorski+open...@gmail.com> wrote:
>> Also I'm not sure the location is correct - maybe it should rather be
>> linux/mtd/bcm963xx_tag.h or mtd/bcm963xx_tag.h something like that -
>> linux/ is just so ... generic.
> Hmm, maybe.. but I don't see any clear precedent for linux/mtd, and
> myloader.h was in linux/mtd so I figured better to keep all instances
> in one place. If at some point there is a clear reason to move to
> linux/mtd, they can all be moved at once. What do you think?

myloader.h isn't upstream, but OpenWrt local, so it's easy to move
"all" of the headers into a different location.

>> Also, can you please submit this upstream, too? I think the idea is
>> good, it's just some details that need to be fixed.
> Sounds good, will do. I'll wait until we iron out the kinks here though?

Yes, please. Although it might mean ironing out more things by then ;-).

>> Oh, and don't forget that there is a linux-3.6 also in trunk.
> Same - I'll get the patch cleaned up for the current linux, then I
> will port to linux-3.6. I guess 3.6 introduces UAPI, so that might be
> a different beast entirely.

Haven't looked at 3.6 in detail there, so I can't really comment here.


Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to