Hi. I've submitted this patch some time ago but haven't seen any response or feedback to it. I believe that this patch fixes very specific, serious and easily reproducible issue on a specific hardware.
I would appreciate if somebody could let me know if I've sent this patch in wrong format or into wrong mailing list or if I did anything else that prevents this patch from being reviewed/included. Thanks! 2013/7/18 Nikolay Martynov <[email protected]> > Looks like trunk@37090 has changed the logic that determines if router's > button was pressed. This resulted in TEW632BRP always booting into failsafe > mode because it detected pressed button (which was not pressed). > > Measure with voltmeter has shown that buttons on this router are actually > active-low. This patch reflects this fact in board configuration and fixes > 'load info failsafe mode' issue. > > Note: it looks like Trendnet TEW632BRP and a close relative to TEW-652BRP > V1.0 and D-Link DIR-615C1, so same problem may exist on those routers as > well. This patch doesn't affect routers other than 632BRP and unfortunately > I do not have hardware to test this issue with other routers. > > This patch fixes #13893 and is tested on actuall Trendnet TEW632BRP. > > Signed-off-by: Nikolay Martynov <[email protected]> > --- > target/linux/ar71xx/files/arch/mips/ath79/mach-tew-632brp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-tew-632brp.c > b/target/linux/ar71xx/files/arch/mips/ath79/mach-tew-632brp.c > index b76d4a7..855664e 100644 > --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-tew-632brp.c > +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-tew-632brp.c > @@ -54,12 +54,14 @@ static struct gpio_keys_button tew_632brp_gpio_keys[] > __initdata = { > .code = KEY_RESTART, > .debounce_interval = TEW_632BRP_KEYS_DEBOUNCE_INTERVAL, > .gpio = TEW_632BRP_GPIO_BTN_RESET, > + .active_low = 1, > }, { > .desc = "wps", > .type = EV_KEY, > .code = KEY_WPS_BUTTON, > .debounce_interval = TEW_632BRP_KEYS_DEBOUNCE_INTERVAL, > .gpio = TEW_632BRP_GPIO_BTN_WPS, > + .active_low = 1, > } > }; > > -- > 1.8.1.2 > > -- Martynov Nikolay. Email: [email protected]
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
