On 07/02/14 03:18, Felix Kaechele wrote:
> I guess you got that piece of code wrong.
>
> The first argument to the ath79_wmac_set_ext_lna_gpio function refers to
> the TX chain, not the value to be written to the GPIO.
>
> So everything is fine here.
Without sounding rude here, are you sure? My look was first prompted by
this comment on my web site:
"I’m see a similar issue as Andy, with the latest builds.
To get connected with 5GHz, you need to be sitting almost in-front of
the N750.
Steve, could you explain the difference of the patch you submitted and
the code that replaced your patch. It was my understanding that you were
setting the GPIO pins to high to fix the reception issues.
On the new code it seems that one is set to high and the other one to low.
Your code:
181 gpio_request_one(MYNET_N750_GPIO_EXTERNAL_LNA0,
182 GPIOF_OUT_INIT_HIGH | GPIOF_EXPORT_DIR_FIXED,
183 “External LNA0″);
184 gpio_request_one(MYNET_N750_GPIO_EXTERNAL_LNA1,
185 GPIOF_OUT_INIT_HIGH | GPIOF_EXPORT_DIR_FIXED,
186 “External LNA1″);
The new code:
ath79_wmac_set_ext_lna_gpio(0, MYNET_N750_GPIO_EXTERNAL_LNA0);
ath79_wmac_set_ext_lna_gpio(1, MYNET_N750_GPIO_EXTERNAL_LNA1);"
In this, 'your patch' was the original patch to fix this by yourself.
This was heavily refactored before merging into trunk.
The original code seems to be setting both to high - whereas the new
code seems only to set one high.
After applying this patch, the reply to the comment states:
"Thanks Steve, I just tested the image with the new patch.
I can confirm that it is working a lot better"
While it could be a random coincidence, I don't have any evidence
further than this to say that it isn't.
If others have an N750 that they could test on, I have a built image
with this patch included at:
http://openwrt.crc.id.au/r39504/
Builds on my site earlier than r39499 do not have this patch applied as
a comparison. I would love to get further testing before we write this
off - just to make sure.
--
Steven Haigh
Email: [email protected]
Web: https://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
