On 2014-05-27 12:41, [email protected] wrote: > hi, all: > we will try to add one feature for AR8337 switch: port ingress rate limit. > we can use swconfig extension command to implement it as below example: > swconfig dev eth0 set extension_switch "port_rate_limit set port 1 rate > 100000" > Note: in this example, 100000 means 100000Kbps. > 1. We use one special communication command in swconfig "extension_switch" > to transfer the extension command for AR8337 switch enhanced feature. I think that's a bad idea. Supported attributes must be exported as normal swconfig attributes rather than going through a useless layer of indirection.
Also, duplicating structs or functions of ar8216.c into ar8216_ext.c is not acceptable. There is also lots of redundant boilerplate stuff in the register definitions that needs to be cleaned up. There's a lot of unnecessary abstraction to get rid of, which will make the code much smaller and more readable. - Felix _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
