Hi Arjen,

I've reverted the commit for now. Another approach might be to use
mtdconcat and set it up from the mach file.

Thanks,

- Felix

On 2016-01-22 20:11, Arjen de Korte wrote:
> This doesn't look good. This patch will move the location of the  
> 'caldata_backup' partition from the factory default location
> 
> 0x000001fc0000-0x000002000000 : "caldata_backup"
> 
> to
> 
> 0x000007fc0000-0x000008000000 : "caldata_backup"
> 
> But since the data of this partition is not moved beforehand, the  
> previous location will be overwritten by the larger "firmware"  
> partition and the new location will probably contain nothing but FF.  
> While I agree it is a waste to not use the 96 MB in location  
> 0x000002000000-0x000008000000, just moving the "caldata_backup"  
> partition to a new location and hope for the best is not a good  
> solution.
> 
> Regards, Arjen
> 
> Citeren [email protected]:
> 
>> Author: nbd
>> Date: 2016-01-17 12:16:56 +0100 (Sun, 17 Jan 2016)
>> New Revision: 48276
>>
>> Modified:
>>    trunk/target/linux/ar71xx/image/Makefile
>> Log:
>> ar71xx: Use full 128MB flash on Netgear WNDR4300 and WNDR3700v4
>>
>> Change MTD on WNDR4300 and WNDR3700v4 to fully utilize the 128MB flash.
>>
>> Credit to @Tuochenlyu on GitHub.
>>
>> Signed-off-by: Chris Marchesi <[email protected]>
>>
>> Modified: trunk/target/linux/ar71xx/image/Makefile
>> ===================================================================
>> --- trunk/target/linux/ar71xx/image/Makefile 2016-01-17 11:16:52 UTC  
>> (rev 48275)
>> +++ trunk/target/linux/ar71xx/image/Makefile 2016-01-17 11:16:56 UTC  
>> (rev 48276)
>> @@ -1581,7 +1581,7 @@
>>   
>> wnr2000v4_mtdlayout=mtdparts=spi0.0:192k(u-boot)ro,64k(u-boot-env)ro,3776k(firmware),64k(art)ro
>>   
>> r6100_mtdlayout=mtdparts=ar934x-nfc:128k(u-boot)ro,256k(caldata),256k(caldata-backup),512k(config),512k(pot),2048k(kernel),122240k(ubi),25600k@0x1a0000(firmware),2048k(language),3072k(traffic_meter)
>>   
>> tew823dru_mtdlayout=mtdparts=spi0.0:192k(u-boot)ro,64k(nvram)ro,15296k(firmware),192k(lang)ro,512k(my-dlink)ro,64k(mac)ro,64k(art)ro
>> -wndr4300_mtdlayout=mtdparts=ar934x-nfc:256k(u-boot)ro,256k(u-boot-env)ro,256k(caldata),512k(pot),2048k(language),512k(config),3072k(traffic_meter),2048k(kernel),23552k(ubi),25600k@0x6c0000(firmware),256k(caldata_backup),-(reserved)
>> +wndr4300_mtdlayout=mtdparts=ar934x-nfc:256k(u-boot)ro,256k(u-boot-env)ro,256k(caldata),512k(pot),2048k(language),512k(config),3072k(traffic_meter),2048k(kernel),120832k(ubi),122880k@0x6c0000(firmware),256k(caldata_backup),-(reserved)
>>   
>> zcn1523h_mtdlayout=mtdparts=spi0.0:256k(u-boot)ro,64k(u-boot-env)ro,6208k(rootfs),1472k(kernel),64k(configure)ro,64k(mfg)ro,64k(art)ro,7680k@0x50000(firmware)
>>   
>> mynet_n600_mtdlayout=mtdparts=spi0.0:256k(u-boot)ro,64k(u-boot-env)ro,64k(devdata)ro,64k(devconf)ro,15872k(firmware),64k(radiocfg)ro
>>   
>> mynet_rext_mtdlayout=mtdparts=spi0.0:256k(u-boot)ro,7808k(firmware),64k(nvram)ro,64k(ART)ro
>> _______________________________________________
>> openwrt-commits mailing list
>> [email protected]
>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-commits
> _______________________________________________
> openwrt-devel mailing list
> [email protected]
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
> 
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to