Hi, Thank you for the reviewing.
On Sat, Aug 31, 2019 at 11:32:33PM +0200, [email protected] wrote: > > + xiaomi,mir3g-v2) > > + ucidef_add_switch "switch0" \ > > + "2:lan:2" "3:lan:1" "4:wan" "6t@eth0" > > + ;; > > "6t@eth0" and "6@eth0" should be the same, so this can be merged with > cudy,wr1000. > > > + xiaomi,mir3g-v2) > > + wan_mac=$(mtd_get_mac_binary factory 0xe006) > > + ;; > > This can be merged with elecom,wrc-1167ghbk2-s|\ etc. The question is whether it should be merged. I can see both positives (less places to change if/when scripts are refactored) and negatives (not easy to compare with other probably related devices from the same manufacturer). If the current practice is to merge everything mergeable, sure, I can send a v4 with that. I'm rather worried by the lack of feedback from R4AG developers/users though! -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:[email protected] _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
