Hi,

> > > + xiaomi,mir3g-v2)
> > > +         wan_mac=$(mtd_get_mac_binary factory 0xe006)
> > > +         ;;
> >
> > This can be merged with elecom,wrc-1167ghbk2-s|\ etc.
> 
> I rebased to current master and added label_mac (as per Roger's
> suggestion), and since I can not be sure about all the other devices,
> I left the dedicated section for this model.

Yes, merging only makes sense if cases are exactly the same. With the addition 
of label_mac (providing additional information), you cannot merge this anymore. 
(So, you did it correctly in v4).

Best

Adrian 

Attachment: openpgp-digital-signature.asc
Description: PGP signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to