> -----Original Message----- > From: Kristian Evensen [mailto:[email protected]] > Sent: Sonntag, 3. November 2019 14:35 > To: Adrian Schmutzler <[email protected]> > Cc: OpenWrt Development List <[email protected]> > Subject: Re: [OpenWrt-Devel] [PATCH v3 2/2] ramips: Add support for ZBT > WE1026-H > > Hi Adrian, > > On Sun, Nov 3, 2019 at 12:36 PM <[email protected]> wrote: > > > > Hi Kristian, > > > > > -----Original Message----- > > > From: openwrt-devel [mailto:openwrt-devel- > [email protected]] > > > On Behalf Of Kristian Evensen > > > Sent: Samstag, 2. November 2019 15:19 > > > To: [email protected] > > > Cc: Kristian Evensen <[email protected]> > > > Subject: [OpenWrt-Devel] [PATCH v3 2/2] ramips: Add support for ZBT > > > WE1026-H > > > > I've already pulled your patches into my staging tree, but then stumbled > over the USB LED as Power LED thing: > > > > https://git.openwrt.org/openwrt/staging/adrian.git > > > > I personally don't like that very much, and it also doesn't strictly match > > the > policy of sticking to the vendor's use of LEDs. However, we also do not > strictly > follow that policy for other devices, e.g. the TP-Link CPE devices where one > of the WLAN strength indicators are used for signaling. > > Still, if the LED is assigned to USB it will at least irritate some users. > > > > Despite that, I remember that for TP-Link WDR3600/WDR4300 a nested > setup was required to get USB hub working: > > > > > https://github.com/openwrt/openwrt/blob/master/target/linux/ath79/dts/ > > ar9344_tplink_tl-wdr4300.dtsi > > > > Maybe you can get USB LEDs working as USB LEDs with that. > > > > Since you seem to keep track on your devices, I'd also be okay with > removing the power_led alias for now, merge the device support, and then > address the USB issue in a separate patch. > > I have no strong opinion either way, as the device is inside an enclosure and > no LEDs are visible on the outside. So feel free to remove the alias. > > BR, > Kristian
Okay, if it's not visible I do not think it's worth to deviate from normal procedure here. I've remove the power_led label and aliases. Feel free to test and provide an updated solution for the use as USB LED. Despite, note that the first word after "ramips:" should be lower-case in commit title for future submissions. Thanks for your work. Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
