On Wed, 20 Nov 2019 at 20:01, Petr Štetiar <[email protected]> wrote:
>
> clang-10 analyzer reports following:
>
> blobmsg_json.c:285:2: warning: The expression is an uninitialized value. The
> computed value will also be garbage
> s->indent_level++;
> ^~~~~~~~~~~~~~~~~
Add else branch to initialize it in setup_strbuf() should suffice.
yousong
>
> Signed-off-by: Petr Štetiar <[email protected]>
> ---
> blobmsg_json.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/blobmsg_json.c b/blobmsg_json.c
> index a5980e8a2b62..18592111b4dd 100644
> --- a/blobmsg_json.c
> +++ b/blobmsg_json.c
> @@ -315,7 +315,7 @@ static void setup_strbuf(struct strbuf *s, struct
> blob_attr *attr, blobmsg_json_
>
> char *blobmsg_format_json_with_cb(struct blob_attr *attr, bool list,
> blobmsg_json_format_t cb, void *priv, int indent)
> {
> - struct strbuf s;
> + struct strbuf s = {0};
> bool array;
> char *ret;
>
> @@ -349,7 +349,7 @@ char *blobmsg_format_json_with_cb(struct blob_attr *attr,
> bool list, blobmsg_jso
>
> char *blobmsg_format_json_value_with_cb(struct blob_attr *attr,
> blobmsg_json_format_t cb, void *priv, int indent)
> {
> - struct strbuf s;
> + struct strbuf s = {0};
> char *ret;
>
> setup_strbuf(&s, attr, cb, priv, indent);
>
> _______________________________________________
> openwrt-devel mailing list
> [email protected]
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
