Yousong Zhou <[email protected]> [2019-11-20 22:03:06]:

> On Wed, 20 Nov 2019 at 20:01, Petr Štetiar <[email protected]> wrote:
> >
> > clang-10 analyzer reports following:
> >
> >  blobmsg_json.c:285:2: warning: The expression is an uninitialized value. 
> > The computed value will also be garbage
> >          s->indent_level++;
> >          ^~~~~~~~~~~~~~~~~
> 
> Add else branch to initialize it in setup_strbuf() should suffice.

Of course, and I even initialy planned to fix it that way, but then decided to
just init the complete struct as it doesn't add another codepath.  So probably
just a matter of taste?

-- ynezz

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to