Hi, > -----Original Message----- > From: openwrt-devel [mailto:[email protected]] > On Behalf Of Koen Vandeputte > Sent: Donnerstag, 27. Mai 2021 13:52 > To: Adrian Schmutzler <[email protected]>; 'Denis Kalashnikov' > <[email protected]>; [email protected] > Cc: 'Gabor Juhos' <[email protected]>; 'Sergey Ryazanov' > <[email protected]> > Subject: Re: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G > > > On 23.05.21 11:01, Adrian Schmutzler wrote: > > ... > >> diff --git a/target/linux/ath79/image/mikrotik.mk > >> b/target/linux/ath79/image/mikrotik.mk > >> index 74f8603b5a..0072ec527d 100644 > >> --- a/target/linux/ath79/image/mikrotik.mk > >> +++ b/target/linux/ath79/image/mikrotik.mk > >> @@ -9,6 +9,15 @@ define Device/mikrotik_routerboard-493g endef > >> TARGET_DEVICES += mikrotik_routerboard-493g > >> > >> +define Device/mikrotik_routerboard-912g > >> + $(Device/mikrotik_nand) > >> + SOC := ar9342 > >> + DEVICE_MODEL := RouterBOARD 912G > >> + DEVICE_PACKAGES += kmod-usb-ehci kmod-usb2 kmod-gpio-beeper > >> + SUPPORTED_DEVICES += rb-912uag-5hpnd rb-912uag-2hpnd endef > > So, both have exactly the same setup as implemented here? > > > > Best > > > > Adrian > > > yes. > > I personally use rb-912uag-5hpnd board. > The hardware is identical with the exception of the band used. > > What's your 2 cents to get both supported using a single target?
I do not have any problems with the presented solution, this was just a question. The naming and organization of the Mikrotik devices in OpenWrt has been an open discussion for quite some time now, and I have given up any hope of finding a solution that will be satisfying all competing requirements. (The only thing that I try to keep consistent for now is having "routerboard-" instead of "rb-" for the "new" names.) So, no objections for the choice made here. Best Adrian > > Thanks, > > Koen > > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
