Hi,
On 2021/11/13 6:15, Sander Vanheule wrote:
As made clear by Paul Fertser, gpio-restart isn't actually used unless
_machine_restart()
is also removed. Although I don't mind adding the correct nodes to the DTS
already (maybe
others disagree). Adding the driver already would only have the effect
(benefit?) of
grabbing the relevant GPIO, and preventing users from using it accidentally.
I definitely think this driver should definitely be enabled, but do we wait
with enabling
it until we can remove _machine_restart? Or can this already be merged as some
sort of
preparatory patch?
IMO, I think that there is no problem because the gpio-restart exists
as a clear specification of this device, and even if the driver is
enabled at the moment, it only does not work and does not interfere
with others.
Regards,
Hiroshi
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
