#16589: ATH10k for Tp-Link Archer C7 V2
-----------------------------+-------------------------------------
Reporter: optimizerapp@… | Owner: developers
Type: defect | Status: new
Priority: normal | Milestone: Barrier Breaker (trunk)
Component: packages | Version: Trunk
Resolution: | Keywords:
-----------------------------+-------------------------------------
Comment (by michal.kazior@…):
Replying to [comment:31 anonymous]:
> In other words, the OTP binary (part of firmware-2.bin) is supposed to
read the OTP data and effectively generate a board.bin. Same problem
though, since the OTP data is stored in a location where ath10k doesn't
know to look (art partition +0x5000).
Wrong. Art partition doesn't contain OTP stream/data at 0x5000. It
contains a board.bin template for the specific board type that was
originally shipped with the platform. The length of the data in the art
partition seems to be 2116 which matches board.bin size. This suggests
there's no additional OTP data there.
> And like I said, temporary hackaround has to be stopping it from bailing
out on the error 2, either by preventing it from running the OTP binary,
or by disregarding the error, and handing it a fallback that makes more
sense than the generic template.
In which case you end up with a mac address from the template unless you
override it manually.
> The part that bugs me about the way ath10k handles the failure is that
in the function ath10k_download_and_run_otp(struct ath10k *ar), a comment
specifically says /* OTP is optional */. If its optional, it really should
NOT bail out on the error at all.
OTP *execution* is optional. OTP is just a program that prepares board
information for main firmware to consume.
You're free to skip the OTP execution but then you're supposed to deliver
a complete board.bin yourself (including mac address, supported bands,
etc).
Ideally I'm thinking the solution is be to have 2 configuration flows:
1) don't provide board.bin template, run otp, run main fw
2) provide board.bin (e.g. via platform data), manually setup missing
bits (mac address, etc)*, run main fw
* this is the difficult part
--
Ticket URL: <https://dev.openwrt.org/ticket/16589#comment:33>
OpenWrt <http://openwrt.org>
Opensource Wireless Router Technology
_______________________________________________
openwrt-tickets mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets
