#19379: Inconsistent config, adding an interface adds quotes to config file
------------------------------------+-----------------------------------
 Reporter:  pinus                   |      Owner:
     Type:  defect                  |     Status:  new
 Priority:  normal                  |  Milestone:  Barrier Breaker 14.07
Component:  luci                    |    Version:  Barrier Breaker 14.07
 Keywords:  luci wireless firewall  |
------------------------------------+-----------------------------------
 Creating a new interface adds quotes to firewall and wireless
 configuration file.
 Comment lines are dropped.

 Either the default configuration should get the quotes (as with the other
 files) or the UI should not add quotes and the others should be removed
 also. This is for consistency.
 These global changes cause the risk of breaking things. It causes the risk
 to hide errors if one of the scripts reading the config files doesn't
 handle the quotes right. For the user there is no relation between the
 change and the breakage.
 I can not prove, but I managed to mess up my configuration multiple times
 and undoing the edit did not return the old state. That is pretty bad
 behavior.

 Another issue is that the comments are removed.

 Steps to reproduce.
 1. Starting with factory default.
 2. Added and activated both wifi interfaces.
 3. Deleted the wan6 interface.
 4. Created a new wifi interface.

--
Ticket URL: <https://dev.openwrt.org/ticket/19379>
OpenWrt <http://openwrt.org>
Opensource Wireless Router Technology
_______________________________________________
openwrt-tickets mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets

Reply via email to