Hi Arne, Congratulations! One question: Do you prefer to rebase PRs prior to merging (i.e., makeing them fully bisectable) or do you to like to keep the fixup patches in the commits of the PRs (for easier reviewing)?
cheers Andreas On Monday 23 September 2013 13:12:06 Arne Morten Kvarving wrote: > Hi there, > > I have been appointed as the maintainer for the upscaling module. > > As i don't have the full overview of the entire code base, i would > appreciate that people who feel responsible for parts of the module to > add themself to the MAINTAINERS file in the root. > > while i will handle the main load, sometimes i will have to ask since i > do not have the full overview > of the code, and having such a list is useful both for me and for users. > > as i am the maintainer i get to set some ground rule. i have two simple > rules: > > NO direct pushes. no matter how trivial the change. i reserve the right > to break my own rule here at my own leisure. this to do maintenance > tasks only (cosmetics and such). you are always free to tell me if i > overstepped my boundaries. > > the only exception here is for common buildsystem changes. @rolk can > push those directly, once they have been reviewed and merged elsewhere. > > secondly, ALWAYS split your commits into logical bits. if you send a > pull with one large "dump" commit, i will reject it no matter the > quality of the code. > > it's not to be difficult. it's out of experience. we ALL screw up at > times, even the simplest of things. i want to catch them before they go > in. we are never in such a hurry. and the splitting really helps keep > the history useful. a vcs is a development tool, not a backup backend or > a convenient way of distributing code (it's those as well but those are > secondary). it's imperative that we can search the history and such and > not encounter broken commits or entangled changes. > > arnem
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Opm mailing list [email protected] http://www.opm-project.org/mailman/listinfo/opm
