On 2013-09-23 13:28, Arne Morten Kvarving wrote:
>>> during the review process you push fixes as separate commits. they
>>> are reviewed. they are ack'd. then it's squashed up. only then is it
On 2013-09-24 00:49, Roland Kaufmann wrote:
I do have to say that I disagree with this view. I *do* agree that
during review we could add revisions with --fixup to ease the
On 2013-09-24 09:35, Arne Morten Kvarving wrote:
i never meant that we'd squash the entire pull up, sorry if that was the
impression. a pull should, as requested, be split into logic commits. as
long as it doesn't break at any of them. i meant you use fixup to adress
comments on the individual commits.
We're on the same page (as usual), then :-)
--
Roland.
_______________________________________________
Opm mailing list
[email protected]
http://www.opm-project.org/mailman/listinfo/opm
