Hello, I have proposed the following patch [1]. It respects backward compatibility in that if there is no file in the project called "docker/docker-list.txt" it behaves identically to the existing code.
If there is a file called docker/docker-list.txt, it iterates over the newline delimited contents as follows: 1. If there is an entry: docker/Dockerfile, it executes identically to the existing code 2. If there is an entry: any-other-path/Dockerfile-othername, it cd to any-other-path and build Dockerfile-othername, and push its image to project-othername as "opnfv/project-othername". So storperf/reporting/docker/Dockerfile-reporting will cause a new image to be pushed which is named "opnfv/storperf-reporting" Please, comments, suggestions, criticism, anything, is more than welcome! [1] https://gerrit.opnfv.org/gerrit/#/c/37041 Regards, Mark Mark Beierl SW System Sr Principal Engineer Dell EMC | Office of the CTO mobile +1 613 314 8106<tel:1-613-314-8106> mark.bei...@dell.com<mailto:mark.bei...@dell.com> On Jul 6, 2017, at 11:42, Yujun Zhang (ZTE) <zhangyujun+...@gmail.com<mailto:zhangyujun+...@gmail.com>> wrote: Does anybody consider using the build service from docker-hub[1] ? It supports multiple Dockerfile from same repository and easy to integrate with OPNFV Github mirror. [1]: https://docs.docker.com/docker-hub/builds/ On Thu, Jul 6, 2017 at 11:02 PM Jose Lausuch <jose.laus...@ericsson.com<mailto:jose.laus...@ericsson.com>> wrote: Hi Mark, I would incline for option 1), it sounds better than searching for a file. We could define specific values of DOCKERFILE var for each project. /Jose From: Beierl, Mark [mailto:mark.bei...@dell.com<mailto:mark.bei...@dell.com>] Sent: Thursday, July 06, 2017 16:18 PM To: opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org> Cc: Julien <julien...@gmail.com<mailto:julien...@gmail.com>>; Fatih Degirmenci <fatih.degirme...@ericsson.com<mailto:fatih.degirme...@ericsson.com>>; Jose Lausuch <jose.laus...@ericsson.com<mailto:jose.laus...@ericsson.com>> Subject: Re: [opnfv-tech-discuss] Multiple docker containers from one project Ideas: * Change the DOCKERFILE parameter in releng jjb so that it can accept a comma delimited list of Dockerfile names and paths. Problem with this, of course, is how do I default it to be different for StorPerf vs. Functest, etc? * Change the opnfv-docker.sh to search for the named DOCKERFILE in all subdirectories. This should cover the .aarch64 and vanilla docker file cases. Please +1/-1 or propose other ideas, thanks! Regards, Mark Mark Beierl SW System Sr Principal Engineer Dell EMC | Office of the CTO mobile +1 613 314 8106<tel:1-613-314-8106> mark.bei...@dell.com<mailto:mark.bei...@dell.com> On Jun 24, 2017, at 04:05, Jose Lausuch <jose.laus...@ericsson.com<mailto:jose.laus...@ericsson.com>> wrote: +1 No need for an additional repo, the logic can be in Releng.. Functest will probably move to different containers some time soon, so that is something we could also leverage. -Jose- On 23 Jun 2017, at 18:39, Julien <julien...@gmail.com<mailto:julien...@gmail.com>> wrote: Agree, If StorPerf can list some rules and examples, current scripts can be adapted for multiple docker image building and other project can use this type of changes. It is not deserved to add a new repo just for build a new image. Fatih Degirmenci <fatih.degirme...@ericsson.com<mailto:fatih.degirme...@ericsson.com>>于2017年6月21日周三 上午2:26写道: Hi Mark, It is perfectly fine to have different build processes and/or number of artifacts for the projects from releng point of view. Once you decide what to do for storperf, we can take a look and adapt docker build job/script to build storperf images, create additional repos on docker hub to push images and activate the builds when things are ready. /Fatih On 20 Jun 2017, at 19:18, Beierl, Mark <mark.bei...@dell.com<mailto:mark.bei...@dell.com>> wrote: Hello, I'd like to poll the various groups about ideas for how to handle this scenario. I have interns working on breaking down services from StorPerf into different containers. In one case, it will be a simple docker compose that is used to fire up existing containers from the repos, but the other case requires more thought. We are creating a second container (storperf-reporting) that will need to be built and pushed to hub.docker.com<http://hub.docker.com/>. Right now the build process for docker images lives in releng, and it only allows for one image to be built. Should I be requesting a second git repo in this case, or should we look at changing the releng process to allow multiple docker images to be build? Regards, Mark Mark Beierl SW System Sr Principal Engineer Dell EMC | Office of the CTO mobile +1 613 314 8106<tel:1-613-314-8106> mark.bei...@dell.com<mailto:mark.bei...@dell.com> _______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org> https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss _______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org> https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss _______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org> https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss _______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org> https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss -- Yujun Zhang _______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org> https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
_______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss