Hi Dhruv, Thanks for the detailed review, please see inline.
Best regards, Bo 发件人: OPSAWG [mailto:[email protected]] 代表 Dhruv Dhody 发送时间: 2021年2月4日 18:13 收件人: Joe Clarke (jclarke) <[email protected]> 抄送: [email protected] 主题: Re: [OPSAWG] CALL FOR ADOPTION: draft-www-opsawg-yang-vpn-service-pm Hi, The work seems to be quite useful. I support adoption by the WG. A few comments - (1) If the model supports L2VPN, I think we need to add the L2-level counters in the vpn-summary-statistics. Currently we only have IPv4 and IPv6 routes. [Bo] Thanks, will add MAC-address-limit counters for L2VPN. (2) Section 3 The performance monitoring information reflecting the quality of the Network or VPN service such as end to end network performance data between source node and destination node in the network or between VPN sites can be aggregated or calculated using, for example, PCEP solution [RFC8233] [RFC7471] [RFC8570] [RFC8571] or LMAP [RFC8194]. I suggest changing "PCEP" to more generic term "Traffic Engineering Database (TED)". [Bo] OK, will update. (3) Section 3.2 3.2. On demand Retrieval via RPC Model To obtain a snapshot of a large amount of performance data from a network element (including network controllers), service-assurance applications may use polling-based methods such as RPC model to fetch performance data on demand. Do you mean the usual Netconf <get>? Not sure about the term "RPC model". Maybe refer to it as just polling mechanism. [Bo] Yes. Thanks for pointing this out, will fix this to refer to the polling mechanism. (4) Section 4.1 I am not sure about the depiction of how PE map to CE and further map to Nodes in the underlying network in Figure 3. In the YANG we have node-type that can be PE, CE, or P and this figure does not help. Its possible I might be seeing it wrong :) Also the mapping in the figure and the text for Node 3 and 4 don't match. In "Site-2 A and B play the role of hub while Site-2 C plays the role of spoke.", did you intend to have 2 hub and 1 spoke? [Bo] Thanks for catching this. Will fix the figure the text. (5) Section 4.2 For network performance monitoring, the attributes of "Network Level" that defined in [RFC8345] do not need to be extended. [RFC8345] does not use the term "Network Level". I am wondering if we should use the full path /nw:networks/nw:network/ or container name instead... Also applicable to 4.3 The "vpn-id" is just a string and would also depend on the network-service-type (L3VPN, L2VPN); IMHO some text to describe this is needed. [Bo] Will update as you suggested. (6) Section 4.3 Not clear on why node-type is marked as (Attribute) but site-id and site-role are (Constraint). Can you expand on "site-id", is this matching with L3SM site-id or L3NM's vpn-network-access? The type should be yang:counter32 instead of uint32 for - +--rw vpn-summary-statistics +--rw ipv4 | +--rw total-routes? uint32 | +--rw total-active-routes? uint32 +--rw ipv6 +--rw total-routes? uint32 +--rw total-active-routes? uint32 [Bo] Thanks for catching the errors. “Constraint” will be corrected to ”Attribute“. For the “site-id”, in most cases, it refers to L3NM's ne-id. In the case of provider-managed CE, it may refers to L3SM site-id. (7) Section 7 (a) identity link-type { base vpn-common:protocol-type; description "Base identity for link type, e.g.,GRE, MPLS TE, VXLAN."; } identity VXLAN { base link-type; description "Base identity for VXLAN Tunnel."; } identity ip-in-ip { base link-type; description "Base identity for IP in IP Tunnel."; } What is the benefit of creating link-type as an identity? Can VXLAN and ip-in-ip directly use vpn-common:protocol-type as a base? [Bo] Thanks for the suggestion. We can directly use vpn-common:protocol-type as the tunnel encapsulation type. (b) leaf outbound-qlen { type uint32; description " Length of the queue of the interface from where the packet is forwarded out. The queue depth could be the current number of memory buffers used by the queue and a packet can consume one or more memory buffers thus constituting device-level information."; } description "Grouping for interface service telemetry."; } Since these are abstract nodes how do we know this information? [Bo] We will remove this. This is from the initial discussion on rfc8532(Generic YANG Data Model for the Management of OAM Protocols That Use Connectionless Communications) . But the published RFC has removed this definition. (c) leaf reference-time { type yang:date-and-time; description "The time that the current Measurement Interval started."; } Shouldn't this be config false? [Bo] Agree. Thanks, will update. == Suggestion: Can we add an example of how percentile is used and reported in the appendix? [Bo] Thanks. Will add the example. Hope you find these comments useful. Thanks! Dhruv On Fri, Jan 29, 2021 at 7:49 PM Joe Clarke (jclarke) <[email protected]<mailto:[email protected]>> wrote: Hello, WG. The draft-www-opsawg-yang-vpn-service-pm (A YANG Model for Network and VPN Service Performance Monitoring) work has been steadily progressing with the other VPN network model work. This was presented last at IETF 109 (https://datatracker.ietf.org/doc/slides-109-opsawg-a-yang-model-for-network-and-vpn-service-performance-monitoring/), and there has been some recent discussion on list that has been addressed by the authors. We would like to know if the working group wants to formally adopt this work. Please respond with your comments and thoughts on the draft. We will conduct a two week CFA, concluding on February 12, 2021. Joe (on behalf of co-chairs) _______________________________________________ OPSAWG mailing list [email protected]<mailto:[email protected]> https://www.ietf.org/mailman/listinfo/opsawg
_______________________________________________ OPSAWG mailing list [email protected] https://www.ietf.org/mailman/listinfo/opsawg
