Hi Éric, 

Thank you for the review. 

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : Éric Vyncke via Datatracker <[email protected]>
> Envoyé : lundi 20 novembre 2023 13:18
> À : The IESG <[email protected]>
> Cc : [email protected]; opsawg-
> [email protected]; [email protected]; [email protected]; [email protected]
> Objet : Éric Vyncke's No Objection on draft-ietf-opsawg-rfc7125-
> update-06: (with COMMENT)
> 
> Éric Vyncke has entered the following ballot position for
> draft-ietf-opsawg-rfc7125-update-06: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut
> this introductory paragraph, however.)
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> # Éric Vyncke, INT AD, comments for draft-ietf-opsawg-rfc7125-update-
> 06
> 
> Thank you for the work put into this document. ROA are indeed critical
> for the
> security and stability of the Internet. As usual for a -bis document,
> I
> reviewed only the diffs.
> 
> Please find below some non-blocking COMMENT points (but replies would
> be
> appreciated even if only for my own education), and one nit.
> 
> Special thanks to Joe Clarke for the shepherd's detailed write-up
> including the
> WG consensus *and* the justification of the intended status.
> 
> I hope that this review helps to improve the document,
> 
> Regards,
> 
> -éric
> 
> # COMMENTS
> 
> ## Misleading file name
> 
> While not important at this stage, this document appears more like a
> 7125-bis
> than a 7125-update.
> 

[Med] The effort started actually as an update but we went for a bis during the 
development of the document. 

> ## Section 3
> 
> In which cases can the Exporter deviate from the SHOULD in `SHOULD use
> reduced-size encoding` ?
> 

[Med] Please note that this SHOULD is inherited from RFC7125.

The SHOULD can be relaxed when the exporter wants the collector to have an 
explicit indication about all the bits. That is indirectly covered by the 
following (also inherited from 7125):

  A Collector receiving this Information Element
  with reduced-size encoding must not assume anything about the
  content of the four bits with bit offset positions 4 to 7.

> # NITS
> 
> ## Section 3
> 
> Suggest to either use actions (on receiving) or roles(i.e., Exporter)
> in all
> clauses in `this Information Element MUST be exported with a value of
> zero and
> MUST be ignored by the Collector`
> 

[Med] I made some changes that you can see at: 
https://github.com/boucadair/-ipfix-rfc7125-update/pull/6/files. Not sure if 
that addresses your comment, though.

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations 
confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce 
message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages 
electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou 
falsifie. Merci.

This message and its attachments may contain confidential or privileged 
information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete 
this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been 
modified, changed or falsified.
Thank you.

_______________________________________________
OPSAWG mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/opsawg

Reply via email to