At 3:26 PM -0400 5/9/01, Daniel F. Savarese wrote:
>BTW, Mark, where's that Perl5Substitution patch you were going to
>post?
Sorry.
Been busy.
I do have a question about coding styles.
I read over the Java coding style and maybe have a couple differences
between mine and it.
I tend to comment in order to separate areas of code.
Is that a problem?
If I submit the diff posting, do you integrate the diff in or do you
further massage it into the tree?
Also, what about testing?
I've done some unit testing (and the code changes are in our own
production system now)... but how does this thing get extensively
tested to make sure I didn't break anything?
I did change a couple behaviors to be more perl like with respect to
the substitution string.
Like if a replacement group int is not found, it is simply no text
where as the current behavior shows a '$' and the int value.
In perl, such a substitution would yield no text.
I also added escpaping (had to for \[ulULE]) for both '$' and '\'.
So just want to make sure I'm doing the process correct.
Thanks for any feedback.
I'll make any adjustments you say I might need to make or I can just
post the diff.
mark
--
---------------------------------------------------------------------------
Mark F. Murphy, Director Software Development <mailto:[EMAIL PROTECTED]>
Tyrell Software Corp <http://www.tyrell.com>
PowerPerl(tm), Add Power To Your Webpage! <http://www.powerperl.com>
---------------------------------------------------------------------------
Families Against Internet Censorship: http://www.netfamilies.org/
