>I also left in the check for instance of String in _calcSub. If we
>aren't worried about backwards compat if anyone has serialized
>instances, I'd like to remove the instance check for String.
Kill it. instanceof was a kluge.
>Are static inner classes considered bad form for this project?
Historically, the code never used inner classes while it was still
maintaining JDK 1.0.2 compatibility. It never introduced inner
classes because the JDK 1.1 and, I believe, even the 1.2 compiler
would inline methods that accessed private members. At run time,
on JVMs with strict class verifiers, the class calling those methods
wouldn't pass the class verifier. Right now, as long as we compile
with the JDK 1.3 compiler or don't use -O with earlier compilers, I
think we're ok with inner classes.
daniel
