On Tue, 2009-06-23 at 21:55 +0100, Patrick Ohly wrote: > * add a "remote rule name" parameter to MAKETEXTWITHPROFILE() and > PARSETEXTWITHPROFILE() [...] > Regarding the code patches (attached for review), do > MAKETEXTWITHPROFILE() and PARSETEXTWITHPROFILE() really have an > *optional* mode parameter as the comment implies? I bet it will crash if > the parameter is not passed because getLocalVar() returns NULL for it. > > But perhaps I'm misunderstanding the macro definition. Does the patch > make sense as it is right now?
I noticed that I must update the parameter definition, otherwise I got undefined behavior (reading past the end of the param array). I see that the "mode" parameter is really defined as optional. Does that mean that the source code doesn't have to check for NULL as return code of getLocalVar()? -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ os-libsynthesis mailing list [email protected] http://lists.synthesis.ch/mailman/listinfo/os-libsynthesis
