On Thu, 2009-06-25 at 07:10 -0700, Lukas Zeller wrote: > Hi Patrick, > > On Jun 24, 2009, at 16:57 , Patrick Ohly wrote: > > >> Regarding the code patches (attached for review), do > >> MAKETEXTWITHPROFILE() and PARSETEXTWITHPROFILE() really have an > >> *optional* mode parameter as the comment implies? I bet it will > >> crash if > >> the parameter is not passed because getLocalVar() returns NULL for > >> it. > > getLocalVar() does not return NULL for it. The optional parameters are > always instantiated but have their default value (0 for integers, > empty string, etc.), and they have the isAssigned()==false status when > they are not passed in a call.
Ah, I see. I ran into such a segfault with the additional parameter that I had added, but at that time hadn't declared it properly. I considered this "remote rule" feature rather important for today's SyncEvolution snapshot, therefore I already went ahead and merged it into the "master" branches of SyncEvolution and libsynthesis on moblin.org. That libsynthesis branch also contains an update of the configure build system: we found that the older libxmltok is source-code compatible with expat 2.0, so now it is possible to use that library if installed on the system. The bundled source code hasn't changed. Would you mind reviewing and integrating these patches into the upstream libsynthesis at some point? -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ os-libsynthesis mailing list [email protected] http://lists.synthesis.ch/mailman/listinfo/os-libsynthesis
