Hi Filip, I've just reviewed this fix and its almost indentical to one I have already checked in.
Cheers Robert. On Oct 8, 2007 8:02 AM, <[EMAIL PROTECTED]> wrote: > Hi Robert, > > I was aware of the binary compatibility breakage, but I got too caught up in > the fact that osgViewer::View was the only place with SceneData. Seeing how > elegantly it can be done makes me a bit embarrassed, but it also proves how > much I have to learn about osg. > > There was a small logical error in the loop for adding the children to the > slave camera. I've attached the fixed version. > > Thanks for this fix, it works great. > > Cheers, > Filip > > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] On > > Behalf Of Robert Osfield > > Sent: 6. oktober 2007 16:59 > > To: OpenSceneGraph Submissions > > Subject: Re: [osg-submissions] Add slave camera > > > > Hi Filip, > > > > I've been wondering about the issue with binary compatibility > > - and adding a virtual function breaks binary compatibility > > which is bad news for 2.2.1. It occurred to me that the only > > way not to break binary compatibility would be to modify the > > existing View::addSlave method so that it copied it's > > Camera's subgraph from the master Camera's subgraph. > > > > I have modified and checked in the modified View.cpp, its > > also attached. I didn't have any example code to reproduce > > the original so could you try at your end? > > > > Cheers, > > Robert. > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
