Thanks Paul, change now merged and submitted to SVN. W.r.t accepting patches rather than whole files, this still not appropriate, patches don't always apply correctly - if we are lucky a compile error will reveal this, otherwise it can just plain introduce bugs without anyone noticing, and the process I have to go through to properly review patch submission means there is far more time has to be spent at me end. Considering that the number of contributors far outweighs the number of reviewers its essential that we keep the cost of reviews down to a minimum, and in terms of code quality its important that any avenue for introducing bugs is closed off - this means avoiding patch and using complete source files.
Robert. On Wed, Mar 5, 2008 at 1:32 PM, Paul Melis <[EMAIL PROTECTED]> wrote: > Hi Robert, > > Here is an updated osgviewerWX example to bring it more in line with the > other GUI toolkit examples. It now takes a model file as command-line > argument (complaining if there isn't one), and its startup window size > is now actually applied (it used to be too small). I tested this with a > unicode-build of wxWidgets, as that is the recommended build type on > Linux with GTK. I'm pretty sure this version of the example will work > for the ANSI build as well, but I have no way of testing. > > Paul > > PS Is there any change that in the future you might start accepting > patches instead of whole files? It's so much more convenient to simply > do a "svn diff > file.patch" than having to find the relevant files > changed and tar them up, plus it makes the it more explicit what has > changed to anyone following the submissions list without having to do a > diff. Subversion actually lists the base revision in its diff output > (see below), which might help in applying renegade patches. > > =================================================================== > --- examples/osgviewerWX/osgviewerWX.cpp (revision 7909) > +++ examples/osgviewerWX/osgviewerWX.cpp (working copy) > @@ -21,17 +21,23 @@ > // `Main program' equivalent, creating windows and returning main app frame > ... > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
