Hi Mathias, Sorry for the delay in reviewing this submission. I have now done the review, and understand the motive behind the submission and plan to merge something like this submission, but I need to thrash out a few details first.
The only issue I have with the submission as is is the OSG_DEFAULT_LIBRARY_PATH that contains the installed library location comes before the LD_LIBRARY path entry. The problem with this is that if a user does in a source build and doesn't install, and instead uses LD_LIBRARY path to pick up on the local OpenSceneGraph/lib directory the new code will instead send it search off in /usr/local/lib prior to looking at LD_LIBRARY_PATH, and this could pick up the wrong version - one that might have been previously installed, but isn't the one intended by the LD_LIBRARY_PATH setting which is a user defined settings that one would expect to take precedence. Now the OSG has so version numbers and the plugin directory has version numbers too so mostly we'll probably get away with this precedence issue, but potentially it could cause problems. My current thought is that we should check for LD_LIBRARY_PATH before the OSG_DEFAULT_LIBRARY_PATH, then the standard system directories. This does complicate the code a bit though, as there are multiple implementations of appendPlatformSpecificLibraryFilePaths where the LD_LIBRARY_PATH (or platform equivalent) and standard system directories are append. Perhaps one could have two methods one for the LD_LIBRARY_PATH variables, then a second with standard system directories, then have you now path in the middle, or with just stick you new addition into the separate append*() function. Thoughts? Robert. On Wed, Sep 3, 2008 at 12:29 PM, Mathias Fröhlich <[EMAIL PROTECTED]> wrote: > > Hi Robert, > > The subject says most of it. > > If nothing different is given by environment variables osg looks by default in > <prefix>/lib<archauffix>/osgPlugins-<version>/ for plugins to load. This > makes osg work on linux without the need to set a LD_LIBRARY_PATH or > something like that. This is very convenient if you have multiple versions of > osg installed for whatever reason. > > The default is not set used if you have a static build. > > The change is abased on rev 8828. > Please apply. > > Greetings > > Mathias > > -- > Dr. Mathias Fröhlich, science + computing ag, Software Solutions > Hagellocher Weg 71-75, D-72070 Tuebingen, Germany > Phone: +49 7071 9457-268, Fax: +49 7071 9457-511 > -- > Vorstand/Board of Management: > Dr. Bernd Finkbeiner, Dr. Florian Geyer, > Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech > Vorsitzender des Aufsichtsrats/ > Chairman of the Supervisory Board: > Prof. Dr. Hanns Ruder > Sitz/Registered Office: Tuebingen > Registergericht/Registration Court: Stuttgart > Registernummer/Commercial Register No.: HRB 382196 > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
