Hi, On Wednesday 17 September 2008 21:59, Robert Osfield wrote: > Sorry for the delay in reviewing this submission. I have now done the > review, and understand the motive behind the submission and plan to > merge something like this submission, but I need to thrash out a few > details first. Not a problem.
> The only issue I have with the submission as is is the > OSG_DEFAULT_LIBRARY_PATH that contains the installed library location > comes before the LD_LIBRARY path entry. The problem with this is that > if a user does in a source build and doesn't install, and instead uses > LD_LIBRARY path to pick up on the local OpenSceneGraph/lib directory > the new code will instead send it search off in /usr/local/lib prior > to looking at LD_LIBRARY_PATH, and this could pick up the wrong > version - one that might have been previously installed, but isn't the > one intended by the LD_LIBRARY_PATH setting which is a user defined > settings that one would expect to take precedence. I see the problem. I did not look too deep into the platform specific stuff. I thought that we just append /lib and /usr/lib here ... > Now the OSG has so version numbers and the plugin directory has > version numbers too so mostly we'll probably get away with this > precedence issue, but potentially it could cause problems. Sure ... > My current thought is that we should check for LD_LIBRARY_PATH before > the OSG_DEFAULT_LIBRARY_PATH, then the standard system directories. > This does complicate the code a bit though, as there are multiple > implementations of appendPlatformSpecificLibraryFilePaths where the > LD_LIBRARY_PATH (or platform equivalent) and standard system > directories are append. Perhaps one could have two methods one for > the LD_LIBRARY_PATH variables, then a second with standard system > directories, then have you now path in the middle, or with just stick > you new addition into the separate append*() function. > > Thoughts? I believe that the 'stick in between with a seperate function' solution is good. Attached ... Greetings Mathias -- Dr. Mathias Fröhlich, science + computing ag, Software Solutions Hagellocher Weg 71-75, D-72070 Tuebingen, Germany Phone: +49 7071 9457-268, Fax: +49 7071 9457-511 -- Vorstand/Board of Management: Dr. Bernd Finkbeiner, Dr. Florian Geyer, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech Vorsitzender des Aufsichtsrats/ Chairman of the Supervisory Board: Prof. Dr. Hanns Ruder Sitz/Registered Office: Tuebingen Registergericht/Registration Court: Stuttgart Registernummer/Commercial Register No.: HRB 382196
default-path-2.tar.bz2
Description: application/tbz
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
