Hi Christophe, I've just reviewed your changes, and am bit confused by the code - not your changes in particular, but rather than the fact that original code claims support for 16bit samples but then the copy_row function that just copies unsigned char's across. You could fixes the 32bit case, but doesn't address the 16bit case.
I also feel that the we could probably just get rid of the copy_row function and use memcpy instead, and just compute the size of the row needing to be copied. i.e. memcpy(currPtr, inbuf, format*w); Before I merge any changes I'll need to test before and after results with some real imagery that tests 8bit, 16bit and float. Do you have some I could test against? Robert. On Thu, Sep 11, 2008 at 2:14 PM, christophe loustaunau <[EMAIL PROTECTED]> wrote: > Hi, > > Here is a little change to the tiff plugIn that allow the user to read a > float TIFF file. > > Patch based on the svn version. > > Regards. > > -- > Christophe Loustaunau. > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
