Hi Robert, "Christopher Blaesius" is just fine, thx. -----Ursprüngliche Nachricht----- Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von Robert Osfield Gesendet: Donnerstag, 18. September 2008 16:22 An: OpenSceneGraph Submissions Betreff: Re: [osg-submissions] osgShadow::SoftShadowMap derrived fromShadowMap
HI Christopher, I've now merged your changes, but had to fix the doxygen comment for the SoftShadowMap as somehow you'd copied and pasted the ShadowTexture docs in, and also had to remove quite a bit of indentation/redundant spaces/tabs that made their way into the header which were not their before, curiously the .cpp looked fine. Testing osgshadow with --ssm suggests that the changes work fine so are now all checked into svn. I went with the name Christopher Blaesius in the check-in. Robert. On Thu, Sep 18, 2008 at 2:32 PM, Robert Osfield <[EMAIL PROTECTED]> wrote: > Hi Christopher, > > I'm just about to review your changes, if I do merge them I'll be > assigned you name to the svn checkin message, but svn does like > extended character set, so will reject the ä in your name. What > would be the best way to write your surname? Your email address uses > Blaesius, would this be appropriate for the svn message? > > Robert. > > On Mon, Sep 1, 2008 at 11:38 PM, Christopher Bläsius > <[EMAIL PROTECTED]> wrote: >> Hi, >> Soft shadow mapping is basically the same as hard shadow mapping beside that >> it uses a different fragment shader. >> So for me it makes sense that osgShadow::SoftShadowMap is derived from >> osgShadow::ShadowMap, this makes it easier to maintain the two classes. >> Additional SoftShadowMap also provides the same Debug methods as ShadowMap. >> >> Greets >> Christopher Bläsius >> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph. org >> >> > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph. org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
