Hi,

On Thursday 09 October 2008 10:14, Wojciech Lewandowski wrote:
> All the above cases could be changed as you have done.
>
> > And from the code it is not clear to me that the vector is empty in any
> > case.
> > At least the mergeFaces case looks unclear.
>
> In 2 cases vector is empty after creation by Face constructor and in 3 case
> (mergeFaces) vector is cleared before entering the scope where insert from
> deque is performed.
>
> > May be you can take a look if that different code is really guaranteed to
> > do
> > the same?
>
> Yes, It looks correct to me. There will be no functional difference.
Great, thanks!

Greetings Mathias

-- 
Dr. Mathias Fröhlich, science + computing ag, Software Solutions
Hagellocher Weg 71-75, D-72070 Tuebingen, Germany
Phone: +49 7071 9457-268, Fax: +49 7071 9457-511
-- 
Vorstand/Board of Management:
Dr. Bernd Finkbeiner, Dr. Florian Geyer,
Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Prof. Dr. Hanns Ruder
Sitz/Registered Office: Tuebingen
Registergericht/Registration Court: Stuttgart
Registernummer/Commercial Register No.: HRB 382196 


_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to