Hi Mathias and Blasius, I think perhaps we need to break this submission into the BSD support part and then any changes required for static building under windows. I'll revert all the changes I've applied and suck out all the uncontroversial parts of Blasius's submission, then once this is checked and tested across platforms we can look at the next step.
Robert. On Wed, Oct 15, 2008 at 10:10 AM, Mathias Fröhlich <[EMAIL PROTECTED]> wrote: > > Hi Blasius, > > On Tuesday 14 October 2008 18:42, Robert Osfield wrote: >> Could you explain why did you move the include<OpenThreads/Config> >> from Atomic to Export, as Export is really just for defining the >> Export token and nothing else. > I agree with Robert, this include should not move. > It already is where it is needed. > >> The rest changes I believe look OK, but this code is Mathias's baby so >> I'm not an expert on it yet. > > Great to have BSD support! Thanks! > > One major issue: > You cannot remove the '&& defined(__i386__)' from the gcc builtin case. That > will make the success of a build using osg headers depend on the compiler > flags. > That must be changed. That is plain wrong. > > You implemented the win32 case with that intrin.h header and functions from > there. Is there a minimum requirement to the compiler to have that header and > these functions? > Are these intrinsics availabe for *any* set of compile flags of cl? > If so, may be it is better to move the whole win32 case over to these > intrinsics??? > > Why is the OT_LIBRARY_STATIC added to the config file? It is not needed > anywhere. > > For interrest: what is that implementation for? This is not used anywhere in > osg. Is there a change to osg pending? > > Greetings and thanks! > > Mathias > > -- > Dr. Mathias Fröhlich, science + computing ag, Software Solutions > Hagellocher Weg 71-75, D-72070 Tuebingen, Germany > Phone: +49 7071 9457-268, Fax: +49 7071 9457-511 > -- > Vorstand/Board of Management: > Dr. Bernd Finkbeiner, Dr. Florian Geyer, > Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech > Vorsitzender des Aufsichtsrats/ > Chairman of the Supervisory Board: > Prof. Dr. Hanns Ruder > Sitz/Registered Office: Tuebingen > Registergericht/Registration Court: Stuttgart > Registernummer/Commercial Register No.: HRB 382196 > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
