Hi Blasius, On Wednesday 15 October 2008 16:13, Blasius Czink wrote: > > One major issue: > > You cannot remove the '&& defined(__i386__)' from the gcc builtin case. > > That will make the success of a build using osg headers depend on the > > compiler flags. > > That must be changed. That is plain wrong. > > Right, skip that change. It slipped in accidentally. The attache header is ok wrt this problem.
> I tested with VS2005 and VS2008. For 32 bit everything works as > expected. For x64 and VS2008 I could successfully do the cmake-configure > and then the compilation but I had occasional crashes of > cmTryCompileExec.exe (during the cmake-configure phase) which seems to > be a cmake bug. With VS2005 and 64bit cmake does not set > _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED although the interlocked > functionality should be there. If I place the source snippet from the > CHECK_CXX_SOURCE_RUNS macro to a separate sourcefile I can compile and > run the resulting executable successfully. Forcing > OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED (on VS2005/x64) reveals a bug > in "intrin.h" which seems to be fixed in VS2008 but not in VS2005. Ok, recently i had experienced similar problems with cmake. If I call cmake for the first time it does not find msvcrt*.dll and the test fails. The gui variant just fails silently but the command line variant tells me that it does not find the dll. When I remove the CMakeCache.txt and rerun the same cmake call with exactly the same parameters, the test is successful and everthing works as expected ... May be this helps for you too?? > The worst thing that can happen is that interlocked funtionality is not > detected during cmake-configure and the mutex fallback is used. So correctness is there in any case. I am not sure from the above, it usually works on vs2005 even on 64 bits? > Which reminds me another small glitch in the Atomic header so I attached > a corrected version. Thanks. > > Why is the OT_LIBRARY_STATIC added to the config file? It is not needed > > anywhere. > > OT_LIBRARY_STATIC is needed if you are doing static-builds on Windows. > See my previous post on that. Ah ok, now I see also why you moved Config to Exports ... Hmm, my feeling would be to still include the Config file in Atomic, just because I need it there. If for one reason the Config again vanishes from exports for some unkown and unrelated reason it is still included in Atomic where it is needed to guarantee correctness. But that would be my choice which is not always Roberts :) Robert? Greetings Mathias -- Dr. Mathias Fröhlich, science + computing ag, Software Solutions Hagellocher Weg 71-75, D-72070 Tuebingen, Germany Phone: +49 7071 9457-268, Fax: +49 7071 9457-511 -- Vorstand/Board of Management: Dr. Bernd Finkbeiner, Dr. Florian Geyer, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech Vorsitzender des Aufsichtsrats/ Chairman of the Supervisory Board: Prof. Dr. Hanns Ruder Sitz/Registered Office: Tuebingen Registergericht/Registration Court: Stuttgart Registernummer/Commercial Register No.: HRB 382196 _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
