Hi Paul,

This is a very simple but powerful change to the osgManipulator
"Dragger" class, it allows you to specify your own custom geometry for
a dragger when you create it. The actual osg changes are very simple,
but I have also included an example of how to use it (because that is
the hardest bit). I think the how to use comments should be added to
the Dragger code somewhere (Dragger.cpp?).

Not that I'm against making it easier to specify dragger geometry. Far from it. So please take this as constructive criticism.

It's already possible to use custom geometry by simply subclassing the dragger and creating the geometry however you want. You don't even have to subclass, come to think of it. After all, the geometry is just a child of the dragger (which is a subclass of MatrixTransform)...

Plus, in the case of complex draggers like the TranslateAxisDragger or the TrackballDragger, you need to say that a specific part of the geometry is used for a certain behavior of the dragger, which is done by setting the geometry as child of only part of the dragger. You can do that by subclassing the dragger (since the "sub-draggers" are protected) but I don't see how it can be done with a simple call to setupCustomGeometry (note that I haven't looked at the code at all, so perhaps you've thought of this, in which case it removes my major concern about the change).

So if you can say without a doubt that this submission makes things possible which were not before (or makes them easier), and allows all draggers to have custom geometry and behave as they should, then I'm all for improving the interfaces.

J-S
--
______________________________________________________
Jean-Sebastien Guay    [EMAIL PROTECTED]
                               http://www.cm-labs.com/
                        http://whitestar02.webhop.org/
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to