Robert Osfield wrote:
Hi Tim,
I've merged your changes with svn/trunk and everything builds when I
do use the wrappers, but if run the make wrappers and the build the
wrappers I get many hundreds of build errors. I don't know how
whether it's possible to fix these errors without disabling the
wrapping of BoundingBox and BoundingSphere completely. Perhaps mods
to src/osgWrappers/genwrapper.conf would do the trick, perhaps mods to
genwrapper source code itself.
I have lots of other work to complete, so fixing all the problems that
this submission brings with it isn't something I can take on, so for
the time being I'm going to have to reject this submission.
I'll take a look. I usually don't build the wrappers, in order to save
some time; obviously that bit me :)
Perhaps one solution, albiet a bit crude would be to implement the
BoundingBox/Sphere double and float versions as separate headers, and
have a single implementation in to the .cpp as is done for the Matrix
class. It does throw away one of the strengths of C++ but it would
solve the wrapping issues.
A couple of side notes, the use of member templates can cause cross
platform build problems, and the NumberTraits<double> implememtation
returns a DBL_MAX as a float, whereas it should be a double:
template<>
class NumberTraits<double>
{
public:
static inline float maxNumber() { return DBL_MAX; }
};
When I did the merge I avoided the use of NumberTraits completely,
instead just using FLT_MAX in the init codes as this is sufficient for
the way BoundingBox functions in either float or double cases.
Whoops, that was an error. I thought the consensus was that member
templates were generally OK, though there can be STL-related issues?
Tim
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
