Hi Urlich, I've just reviewed your bmp fixes and note that you've kept the old code in place but effectively #ifdef'd out. Given the function that you've replace is rather long I think it would be a easy to make mistakes reading the code and not realizing that the much of the code is not used at all. My preference would be to remove the old code completely and just use the svn repository as the place for the previous version of the code.
Thoughts? Robert. On Mon, Nov 17, 2008 at 9:47 AM, Ulrich Hertlein <[EMAIL PROTECTED]> wrote: > Hi all, > > on the weekend I noticed some regression in the BMP loader - some 8-bit > (paletted) files wouldn't load anymore but simply crash. > > After taking a look at the current state of the BMP loader I decided it > might be worth a shot at reimplementing that part. For example: the current > loader doesn't properly handle 1- and 4-bit files, incorrectly loads 16-bit > files as intensity-alpha (they are RGB555), is full of dead code, and > generally not in very good shape. > > Attached is my re-implementation for review. > > I've checked it against the test images from > http://wvnvaxa.wvnet.edu/vmswww/bmp.html and models that use BMP files. > > Cheers, > /ulrich > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
