Hi Sukender, This a reasonable change - the add/remove/replace/set methods all are only called small number of times in the objects lifetime so would not hinder performance in any practical way and would make the class more extensible/reusable. These methods have all now been made virtual and their implementations moved to the .cpp file. An svn updatewill get you these changes.
Robert. On Tue, Nov 18, 2008 at 1:56 PM, Sukender <[EMAIL PROTECTED]> wrote: > Hi everyone, > > Do you think it could be wise to make > osgParticle::ParticleSystemUpdater::addParticleSystem() and > removeParticleSystem() virtual? > > Actually, I have a class that is *VERY* close to ParticleSystemUpdater (named > "AutoParticleSystemUpdater", it destroys particle systems that don't have > particles anymore), but I need to redefine addParticleSystem() and > traverse(). The last one is already virtual, but not addParticleSystem(), so > I did an ugly copy of the class instead of derivating it. > What do you think about it? > > Sincerely, > > Sukender > PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/ > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
