Hi Jaromir,

I've tracked this build issue down to the fact that my glxext.h which
is inclined from my gl.h, defines GL_EXT_framebuffer_object so that
the OSG's include/osg/FrameBufferObject doesn't need to define, but in
the glext.h the GL_STENCIL_INDEX_EXT has been removed.  Tracking this
down to OpenGL extension specs, it turns out that this token has been
removed from the spec.

   http://www.opengl.org/registry/api/enumext.spec

So I've also comment it out from the include/osg/FrameBufferObject
header, which could break other builds, but since this token has been
removed from the spec there is a good chance that it isn't safe to
use.

For the osgpackeddepthstencil example I've used GL_STENCIL_INDEX8_EXT
instead of  GL_STENCIL_INDEX8_EXT. I presume this is appropriate.

With my change in place I've now merged and submitted to SVN your change.

Robert.

On Mon, Nov 24, 2008 at 4:58 PM, Robert Osfield
<[EMAIL PROTECTED]> wrote:
> Hi Jaromir,
>
> I've just attempted a merge, but am getting an error:
>
> home/robert/OpenSceneGraph/examples/osgpackeddepthstencil/osgpackeddepthstencil.cpp:
> In function 'int main(int, char**)':
> /home/robert/OpenSceneGraph/examples/osgpackeddepthstencil/osgpackeddepthstencil.cpp:182:
> error: 'GL_STENCIL_INDEX_EXT' was not declared in this scope
>
> My gl.h only contains GL_STENCIL_INDEX.   We'll need to define
> GL_STENCIL_INDEX in one of the headers, and make sure that the value
> of GL_STENCIL_INDEX_EXT and  GL_STENCIL_INDEX are consistent.
>
> My gl.h has:
>
> gl.h:#define GL_STENCIL_INDEX                   0x1901
>
> Robert.
>
> On Fri, Nov 21, 2008 at 1:58 PM, Jaromír Vítek <[EMAIL PROTECTED]> wrote:
>> Hi Robert,
>>
>> Thanks for merge. In attachment are another fixes for using packed
>> depth+stencil (PDS).
>>
>> * When used PDS RenderStage::runCameraSetUp sets flag that FBO has already
>> stencil,depth buffer attached. Prevents adding next depth buffer.
>> * Sets correct traits for p-buffer if used PDS and something goes wrong with
>> FBO setup or p-buffer is used directly.
>> * Adds warning to camera if user add depth/stencil already attached through
>> PDS.
>> * Sets blitMask when use blit to resolve buffer.
>>
>> There is also new example with using multisampled FBO.
>>
>> Jaromir.
>>
>> Robert Osfield napsal(a):
>>>
>>> Thanks for the example, now merged and submitted to SVN.
>>>
>>> On Sun, Nov 9, 2008 at 9:28 PM, Jaromír Vítek <[EMAIL PROTECTED]>
>>> wrote:
>>>
>>>>
>>>> Hi Robert,
>>>> Thank you for your review and aditional fix. I will change better myself
>>>> next time. I have prepared a test case for new feature.
>>>>
>>>> Jaromir.
>>>>
>>>> Robert Osfield napsal(a):
>>>>
>>>>>
>>>>> HI Jaromir,
>>>>>
>>>>> Your changes are now merged and submitted to SVN, as revision 9136.  I
>>>>> haven't been able to test them as you didn't provide a test case.
>>>>>
>>>>> Your submissions was missing .osg and .ive support so I've added this.
>>>>>  The revision number was 9137, could you please look up the changes I
>>>>> made so you know if future what type of additional work is required
>>>>> when you add features to the core OSG.
>>>>>
>>>>> Robert.
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> osg-submissions mailing list
>>>> [email protected]
>>>>
>>>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>>>>
>>>>
>>>>
>>>
>>> _______________________________________________
>>> osg-submissions mailing list
>>> [email protected]
>>>
>>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>>>
>>
>> _______________________________________________
>> osg-submissions mailing list
>> [email protected]
>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>>
>>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to