Hi Ulrich, I'm just do a review of your changes, and I'm not comfortable with moving Normals include and src into osgUtil. The approach that Don took with adding normals is not really a good way to extend the scene graph. Don original wanted to add the Normals object into the core OSG and I rejected it back then, the class hasn't magically become fixed, so it still fails to cross the hurdle of quality to integrate now. While this feature was off in a plugin it could do little harm as setting a precident, but once stuff goes into the core OSG it becomes a template for future coders and bad habits could develop, the class itself is also prone to misuse.
I there for am rejecting the the majority of this submissions, but I will be merging the typo fixes and change to the record camera path handler. I'm happy to discuss merging once we sort out the normal building functionality. The first step is to ask what the role of this custom Geode is. The only thing that distinguishes this geode from any other is that fact that it has a single constructor that takes a reference to node that it builds local geometry for. There aren't any facilities for updating that local geometry when the orignal subgraph is modief, there aren't any way for toggling on/off the normals. These node in effect servers no purpose, one could easily replace it with a function that generates a Geode containing the custom geometry. If one want to create a custom Node for doing this, then it's place would be in osgFX sitting alongside osgFX::Scribe, and something that acts as a decorator of the subgraph that we intend to add normals to. This would take more effort to code, but it'd also be far more flexible and reusable. Robert. On Wed, Dec 10, 2008 at 9:42 AM, Ulrich Hertlein <[email protected]> wrote: > Hi Robert, > > I've created an event handler that computes and displays bounds and normals. > > It toggles between (geode) bounding sphere, geode bounding box, and drawable > bounding boxes. Normals can be viewed as surface or vertex normals > (re-using code from osgPlugins/normals that I've refactored and put in > osgUtil). > > The BoundsNormalsHandler is added to osgviewer, hotkeys are 'B' (bounds) and > 'N' (normals). > > Also included is an additional, optional parameter to > RecordCameraPathHandler to control the frame rate for record/playback. > Default is 25.0, the environment variable takes preference if set. > > I hope you'll find it useful. > Cheers, > /ulrich > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
