Hi Mattias, Thanks for the change. I'm with you with preferring to just used standard CMake variables that do the same thing so I'll sit on this submission (which is I guess what you really want :-).
The ideal solution for me is making this option non advanced. Any ideas how to this? Anybody? Robert. On Tue, Dec 16, 2008 at 2:32 PM, Mattias Helsing <[email protected]> wrote: > Hi Robert, > > Here's a restored BUILD_REF_DOCS. I have added some comments about > what it does. I have given it the more consistent name > BUILD_OSG_REF_DOCS together with two accompanying variables. > > I think I prefer just having BUILD_DOCUMENTATION because I think it's > confusing that I can have BUILD_DOCUMENTATION unticked and still get > working documentation targets. However - it got slightly cleaner with > this submission and people are used to having it. Your call. > > cheers > Mattias > >>On 12/16/08, Mattias Helsing <[email protected]> wrote: >> Hello Robert, >> >> On 12/16/08, Robert Osfield <[email protected]> wrote: >>> HI Mattias, >>> >>> I've just integrated your changes but was a bit confused by the >>> absence of the BUILD_DOCUMENTATION option, till I toggled on the >>> advanced options in ccmake. I don't recall the exact details, but it >>> might have been this reason why the BUILD_REF_DOCS was introduced. >>> Can we tell CMake to not make this an advanced option? >> >> Ah, so thats the catch. I missed it because i have started to use >> cmake-gui switched to "grouped view". I don't we can >> "unmark_as_advanced". I will find a better solution or remove my >> doings regarding BUILD_REF_DOCS. It seemed to be a good place to >> shorten the CMakeLists.txt. "If it looks to good to be true, it >> probably is" >> >> Mattias >> >>> >>> Robert. >>> >>> On Tue, Dec 16, 2008 at 2:27 AM, Mattias Helsing <[email protected]> >>> wrote: >>>> Hi Robert, all >>>> >>>> Added doc/Doxyfiles/openthreads.doxyfile.cmake >>>> Updated all doxyfiles under doc/Doxyfiles. They are now all processed >>>> by cmake but make targets are only generated for >>>> OpenSceneGraphReferenceDocs and OpenThreadsReferenceDocs. The others >>>> can be run with doxygen directly in <builddir>/doc. >>>> Fixed a copy-paste in openthreads sproc and pthreads CMakeLists >>>> Added the osg logo to the html footers >>>> Added possibility to get generation of chm files. >>>> >>>> CMakeLists (toplevel): >>>> Added install of osg and ot reference docs. This also generates >>>> packaging targets of openscenegraph-doc and openthreads-doc if you >>>> have packaging enabled >>>> Removed the unused USING_OP_OT_TRIPLE_SET since there was no way of >>>> enabling it anyway >>>> Removed BUILD_REF_DOCS. IMO it was redundant - BUILD_DOCUMENTATION >>>> does the same thing and we get that anyway from including >>>> Documentation.cmake. >>>> OsgCPack.cmake: >>>> Removed generation of PACKAGE_SRC for msvc >>>> Added special handling for -doc packaging targets - they don't require >>>> system, architecture or compiler >>>> >>>> cheers >>>> Mattias >>>> >>>> _______________________________________________ >>>> osg-submissions mailing list >>>> [email protected] >>>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>>> >>>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >> > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
