Hi Robert

On 1/8/09, Robert Osfield <[email protected]> wrote:
>
> You caught me mid commit, I've now updated to this latest one as well
> and is now checked in.

nice. and it worked great here with cmake-2.6.2

>
> The older VS warning disable block written to replace the #pragma's is
> still not guarded though, so it's not possible to prevent the
> suppression of these warnings.  I think it might be best to # out this
> block of warning disables and use the OSG_DISABLE_MSVC_WARNINGS to
> toggle on/off this warning suppression via the include/osg/Export
> pragma's that are guarded.  I have just checked in this change for
> testing purposes. I.e. the code now looks like:
>
>         # turn off various warnings
>         # foreach(warning 4244 4251 4267 4275 4290 4786 4305 4996)
>         #     SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd${warning}")
>         # endforeach(warning)
>
> Right now what I really need is a listing of all the warnings with the
> OSG_AGGRESSIVE_WARNING_FLAGS on (as it is by default) and the
> OSG_DISABLE_MSVC_WARNINGS set to off, with the above removal of the
> suppressing of warnings.

I've deleted the cache and started fresh with the above requested
options. This seems to take a bit of time so you'll have to wait. If
you want me to digest it somehow just tell me. Otherwise I'll send the
full zip.

Mattias

>
> Warnings in headers is what is probably best to concentrate on fixing
> so that we will just need warning suppression for the OSG build
> itself, and won't have need for #pragama in the headers any more.
>
> Robert.
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to