Hello Mattias,
I also replaced the internally cached variables that managed the aggresive warnings with explicit adding and removing of flags in CXX_FLAGS
Does that mean I won't see the effect of OSG_USE_AGGRESSIVE_WARNINGS in the CMAKE_CXX_FLAGS variable? Because with your changed file, whether I set OSG_USE_AGGRESSIVE_WARNINGS to ON or OFF doesn't seem to have any effect (on CMAKE_CXX_FLAGS inside CMake at least - I didn't test after generating the projects). /W4 never seems to show up, it's always /W3.
For MSVC flags for suppressing warnings were added without any guard. The warnings are in the Export headers anyway.
What is the concensus there? The warnings were being suppressed in two places : compiler flags and pragmas in include/osg/Export... Which one should we choose? You've removed the compiler flags, but I was under the impression (from a post from Robert this morning) that he wants to remove the pragmas and only keep the compiler flags, so that projects can suppress the warnings they want to suppress on their side.
J-S -- ______________________________________________________ Jean-Sebastien Guay [email protected] http://www.cm-labs.com/ http://whitestar02.webhop.org/ _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
