HI Michael, I've done a review of your changes. I've merged the changes to CMakeLists.txt and checked them in to svn/trunk.
The changes to Group::traverse is simply not a step forward for the code, it's more code, and less readable. I'm perplexed by the changes to Polytope, as you've changed one loop to using indicies, but not a second loop. One of main priorities is keeping the OSG code base robust and maintainable, I'm afraid neither of changes to Group nor Polytope advance this, but take a step backwards. It's simply not appropriate to start introducing peculiar workarounds to perfectly valid and optimal OSG code just for one particular compiler's bugs. Robert. On Mon, May 4, 2009 at 6:50 PM, Michael Platings <[email protected]> wrote: > This time with a subject line :P > > Hi Robert, > further to the discussion on Visual C++ checked iterators, I've done some > profiling which suggests that Group::traverse and > Polytope::setAndTransformProvidingInverse are the two functions that would > benefit most from some trivial optimisation. I've attached the changes I've > made, which should be fairly uncontroversial. > For the benefit of those who can disable checked iterators, I've added an > option for CMake. > Thanks > ______________________________________________________________________ > This email and any files transmitted with it are confidential and > intended solely for the use of the individual or entity to whom they > are addressed. If you have received this email in error please notify > the system manager. > > This email has been scanned by the MessageLabs Email Security System. > For more information please visit http://www.messagelabs.com/email > ______________________________________________________________________ > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
