Hi JS,
On Thu, May 7, 2009 at 2:32 PM, Jean-Sébastien Guay
<[email protected]> wrote:
> Well, I was looking for comments as I don't know what the implications are
> in all cases. What have you tested? Are we sure we want to merge this if it
> may break something we just can't test?
Most of your changes aren't controversial - adding parameters and
methods, the only line that might be problematic is:
if (!audio_disabled && delay < -0.010)
So I've replaced it with:
#if 1
// new code from Jean-Sebasiten Guay - needs testing as we're
unclear on the best solution
// If the display delay is too small, we better skip the frame.
if (!audio_disabled && delay < -0.010)
return;
#else
// original solution that hung on video stream over web.
// If the display delay is too small, we better skip the frame.
if (delay < -0.010)
return;
#endif
As it's easy to revert I've checked this in. I've been testing
various files both on the web and local ones I have here and mostly
the ffmpeg plugin is working well, one video when the video rewinds
the the beginning it start stuttering badly, it did his without your
changes applied so it doesn't seem related.
> I've plugged the camera back in. Go ahead and test.
Thanks, now confirmed that it works with your changes, and freezes without them.
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
