Hi Robert,

Robert Osfield wrote:
On Mon, May 18, 2009 at 12:03 PM, Robert Osfield
<[email protected]> wrote:
Hi Paul,

I've reviewed all your changes and they look fine, I've now merged
them and checked them into svn/trunk.  I've also merged them with the
OSG-2.8, but I'm not 100% sure about their affect on ABI
compatibility.  I believe that these changes won't affect ABI
compatibility, as signed char and a  char are one of the same, the
other changes are also effectively just cosmetic.

Thoughts on ABI compatibility?

I have done more background reading and it does look like the ABI
shouldn't change with this change, but I'm still not 100% sure as char
itself can be set to be either of unsigned char or signed char on some
 compilers such as gcc...


Yes, this was also possible with the MIPS compilers on SGI, which teached me to always use "signed char" in my code, whenever I wanted to have a signed 8-bit integer.

Paul

I've gone for merging with OSG-2.8 now so it'll be part of 2.8.1-rc5.
I *really* hope this does break things.

Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org


_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to