Thanks Rene, fix now merged and submitted to svn/trunk and OSG-2.8 branch.
2009/6/18 René Molenaar <[email protected]>: > Hello, > > This is a fix for a bug in the manipulators. > The dragger's corner tabs were no longer in the corners. > This fix places the cornertabs back in the corners. > > I had send this to osg-users a few days ago, but thought i > would resend it to the osg-submissions mailing list. > > Good day, > > Rene > > ---------- Doorgestuurd bericht ---------- > Van: René Molenaar <[email protected]> > Datum: 8 juni 2009 17:14 > Onderwerp: Re: [osg-users] osgManipulator.AntiSquish > Aan: OpenSceneGraph Users <[email protected]> > > > Sure, > > here is the complete modified file osgManipulator/AntiSquish.cpp > from OpenSceneGraph-2.8.1 > > The bug is as described above: > "The dragger's corner tabs are no longer in the corners." > > this fix places the cornertabs back in the corners. > (the manipulator does not make sense otherwise). > > Grtz, > > René > > > 2009/6/8 Robert Osfield <[email protected]> >> >> HI Rene, >> >> Could you post the whole modified file, thanks, >> Robert. >> >> 2009/6/8 René Molenaar <[email protected]>: >> > I reconfirm this same issue in 2.8.1 >> > >> > The solution is simple (AntiSquish.cpp line 149) : >> > >> > // Position >> > if (_usePosition) >> > unsquished.postMult(_position); >> > else >> > unsquished.postMult(_pivot); >> > >> > should be >> > >> > // Position >> > if (_usePosition) >> > unsquished.postMultTranslate(_position); >> > else >> > unsquished.postMultTranslate(_pivot); >> > >> > if needed i can attach a complete file. >> > >> > have a good one, >> > >> > Rene >> > >> > 2009/2/23 Robert Osfield <[email protected]> >> >> >> >> Hi Jonathan, >> >> >> >> This is correct place to report bugs. I've just ran osgmanipulaor and >> >> see the that tabs rendering is indeed wrong. I have briefly looked at >> >> the svn logs and haven't spotted the cause of this regression yet. >> >> It's end of day here so I'll look into this tomorrow. >> >> >> >> Robert. >> >> >> >> On Mon, Feb 23, 2009 at 5:21 PM, Lewis, Jonathan >> >> <[email protected]> wrote: >> >> > Hi, >> >> > >> >> > The behavior of osgManipulator::AntiSquish seems to have changed >> >> > between >> >> > releases 2.6.1 and 2.8.0. I'm not sure what is happening differently >> >> > in >> >> > the >> >> > matrix math, but you can see the result on the TabBoxDragger by >> >> > firing >> >> > up >> >> > the standard osgManipulator example. The dragger's corner tabs are >> >> > no >> >> > longer in the corners. >> >> > >> >> > As a test I replaced the v2.8 AntiSquish node with the v2.6.1 >> >> > AntiSquish >> >> > in >> >> > the TabPlaneDragger, and things looked right again. >> >> > >> >> > Btw, is this the right place to put a bug report like this? >> >> > >> >> > Thanks, >> >> > -Jonathan Lewis >> >> > >> >> > _______________________________________________ >> >> > osg-users mailing list >> >> > [email protected] >> >> > >> >> > >> >> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> >> > >> >> > >> >> _______________________________________________ >> >> osg-users mailing list >> >> [email protected] >> >> >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> > >> > >> > _______________________________________________ >> > osg-users mailing list >> > [email protected] >> > >> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> > >> > >> _______________________________________________ >> osg-users mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
