Hi Robert, Can i suggest we add differents flag for cull, event, update. It can be convenient for the user to select what callback he wants to duplicate.
What do you think ? Cheers, Cedric On Thu, 2009-06-18 at 11:22 +0100, Robert Osfield wrote: > ---------- Forwarded message ---------- > From: Robert Osfield <[email protected]> > Date: Thu, Jun 18, 2009 at 11:22 AM > Subject: Re: [osg-submissions] osg::clone and updatecallback > To: [email protected] > > > Hi Cedric, > > I've now merged, tweaked and checked in to svn/trunk your CopyOp changes. > > The changes I made was to generalise it work with both cull and update > callbacks. > > Cheers, > Robert. > > On Thu, Jun 18, 2009 at 12:13 AM, Cedric > Pinson<[email protected]> wrote: > > Hi Robert, > > > > Here a first version to give you an overview of clone of UpdateCallback. > > I dont know if it's important to do the same things for others > > NodeCallback like cull or event, it could make senses but it's maybe > > something critical with current application. Maybe we could add a copyop > > option to work as before ? What do you think ? > > > > i modified CopyOp CopyOp.cpp and Node.cpp > > > > Cheers, > > Cedric > > > > On Mon, 2009-06-15 at 11:55 +0100, Robert Osfield wrote: > >> HI Cedric, > >> > >> Added support for NodeCallback to CopyOp and beyond does sound > >> reasonable. The only issue I forsee right now is that some users > >> might not fully implement their callbacks so miss out the full copy > >> constructors. If they are doing this are cloning they might meet with > >> problems, but if they are combining these both then they really should > >> implement their code fully... > >> > >> So go for it. I'll have a review of your final changes and if > >> anything problematic jumps out I'll ping you with my thoughts. > >> > >> Cheers, > >> Robert. > >> > >> On Sun, Jun 14, 2009 at 10:51 PM, Cedric > >> Pinson<[email protected]> wrote: > >> > Hi Robert, > >> > > >> > In osgAnimation i need an update callback per Bone, so when i clone a > >> > scenegraph that contains bone it does not duplicate the updatecallback. > >> > I would like to know if you would accept submission that add option in > >> > the CopyOp to duplicate update callback chain. > >> > > >> > I could do that in the osgAnimation::Bone::Bone(const Bone& b, const > >> > osg::CopyOp& copyop); > >> > but maybe it could be better if it works for general case. > >> > > >> > Does it makes sense for you ? > >> > > >> > Cheers, > >> > Cedric > >> > > >> > -- > >> > +33 (0) 6 63 20 03 56 Cedric Pinson mailto:[email protected] > >> > http://www.plopbyte.net > >> > > >> > > >> > _______________________________________________ > >> > osg-submissions mailing list > >> > [email protected] > >> > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >> > > >> > > > -- > > +33 (0) 6 63 20 03 56 Cedric Pinson mailto:[email protected] > > http://www.plopbyte.net > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org -- +33 (0) 6 63 20 03 56 Cedric Pinson mailto:[email protected] http://www.plopbyte.net
signature.asc
Description: This is a digitally signed message part
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
