I like it, it works well. Tested with svn head as of a few hours ago, on
OS X, and was able to explicitly set the buffer attachment masks on a
RTT Camera configured for MSFBO, and not get the display hang that I
previously got when resolving the depth buffer. Please add to svn head!
Seems like unsigned ints are the right thing here. Perhaps each
enumerant bit value could be "1u << 0", 1u << 1", etc., so that they are
unsigned rather than signed.
Paul Martz
Skew Matrix Software LLC
_http://www.skew-matrix.com_ <http://www.skew-matrix.com/>
+1 303 859 9466
Wojciech Lewandowski wrote:
Hi Paul, Robert,
Building on earlier Paul's submission *"**[osg-users] Main branch MSFBO
support change",* I have added implicit buffer mask variables to
DisplaySettings for setting global defaults for Camera FBOs. These mask
variables are named after variables in Camera class. In Paul's
submission they were named _renderBufferMask & _resolveBufferMask but I
renamed them to _implicitBufferAttachmentRenderMask &
_implicitBufferAttachmentResolveMask. DisplaySettings implementation
includes reading of environment vars and command line options. Setters
and getters follow typical OSG naming convention. I also updated names
of ImplictBufferAttachment enum bits to match changed naming scheme.
DisplaySettings now define COLOR and DEPTH as defaults for implicit
buffers. Consequently Camera by default uses the same defaults through
USE_DISPLAY_SETTINGS_MASK. However, particular Camera mask can be easily
overriden through Camera::setImplicitBufferAttachmentMask method. I
hope, that in this way we can have global control over implicit buffer
defaults, and we can still retain fine grained control at Camera level.
I have also replaced original unsigned ints used to store masks to
signed ints because complier resolves enums as signed integer (I got
a number of warnings with unsigned int).
I struggled to define clear self explanatory names. Feel free to change
them again, if you decide such naming scheme is too bloated.
Cheers,
Wojtek Lewandowski
------------------------------------------------------------------------
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
